[webkit-reviews] review granted: [Bug 89124] [Chromium-Android] Should retry a few times when failed to start DumpRenderTree : [Attachment 147649] patch v2 (sleep before retry)

[bugzilla-daemon at webkit.org]

Dirk Pranke <dpranke at chromium.org> has granted Xianzhu Wang
<wangxianzhu at chromium.org>'s request for review:
Bug 89124: [Chromium-Android] Should retry a few times when failed to start
DumpRenderTree
https://bugs.webkit.org/show_bug.cgi?id=89124

Attachment 147649: patch v2 (sleep before retry)
https://bugs.webkit.org/attachment.cgi?id=147649&action=review

------- Additional Comments from Dirk Pranke <dpranke at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=147649&action=review


r+. Leaving as cq? in case you want to make my purely optional change :).

> Tools/Scripts/webkitpy/layout_tests/port/chromium_android.py:494
> +	       time.sleep(2)

View in context: https://bugs.webkit.org/attachment.cgi?id=147647&action=review


r+ ... leaving cq? in case you want to make the change I suggest (it's purely
optional).

> Tools/Scripts/webkitpy/layout_tests/port/chromium_android.py:493
> +		   raise AssertionError('Failed to start DumpRenderTree
application multiple times. Give up.')

You could also do:

for i in range(3):
  if self._start_once(pixel_tests, per_test_args):
    return
  _log.error(...)
  time.sleep(2)
raise AssertionError(...')