[webkit-reviews] review denied: [Bug 89045] [chromium] LayerRendererChromium is not getting visibility messages in single threaded compositing mode. : [Attachment 147643] Patch

[bugzilla-daemon at webkit.org]

James Robinson <jamesr at chromium.org> has denied Michal Mocny
<mmocny at chromium.org>'s request for review:
Bug 89045: [chromium] LayerRendererChromium is not getting visibility messages
in single threaded compositing mode.
https://bugs.webkit.org/show_bug.cgi?id=89045

Attachment 147643: Patch
https://bugs.webkit.org/attachment.cgi?id=147643&action=review

------- Additional Comments from James Robinson <jamesr at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=147643&action=review


> Source/WebCore/platform/graphics/chromium/cc/CCSingleThreadProxy.cpp:263
> +    compositeImmediately();

I don't think it's a great idea to composite when going visible -> not visible
- it's bypassing all of our rate limiting, flow control, etc.

One particular problem is this is going to produce a frame without firing
requestAnimationFrame callbacks, which is bad.