[webkit-reviews] review granted: [Bug 89033] [Chromium] Sub-pixel text rendering is incorrectly used for WebView with transparent background. : [Attachment 147626] Patch

[bugzilla-daemon at webkit.org]

James Robinson <jamesr at chromium.org> has granted David Reveman
<reveman at chromium.org>'s request for review:
Bug 89033: [Chromium] Sub-pixel text rendering is incorrectly used for WebView
with transparent background.
https://bugs.webkit.org/show_bug.cgi?id=89033

Attachment 147626: Patch
https://bugs.webkit.org/attachment.cgi?id=147626&action=review

------- Additional Comments from James Robinson <jamesr at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=147626&action=review


R=me but consider 2-state enum instead of bool for the paint parameter

> Source/WebKit/chromium/src/WebPagePopupImpl.cpp:240
> +    PageWidgetDelegate::paint(m_page.get(), 0, canvas, rect, true);

this is a good sign that we want a two-state enum here instead of a bool - it's
really hard to guess what "true" means in this context.