[webkit-reviews] review granted: [Bug 83047] Mark text with text alternative with blue underline. : [Attachment 147479] Update to TOT.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jun 14 12:13:35 PDT 2012

Enrica Casucci <enrica at apple.com> has granted Jia Pu <jpu at apple.com>'s request
for review:
Bug 83047: Mark text with text alternative with blue underline.

Attachment 147479: Update to TOT.

------- Additional Comments from Enrica Casucci <enrica at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=147479&action=review

The patch looks good. I've added a couple of comments that I would like to see
fixed before you land it. I'll trust you to fix them before landing.

> Source/WebCore/ChangeLog:11
> +	   This patch implements visual indication on dictated text with
alternatives, and providing UI


> Source/WebCore/editing/mac/AlternativeTextUIController.mm:95
> +    NSSpellChecker* spellChecker = [NSSpellChecker sharedSpellChecker];

no need to use the local variable, use directly [NSSpellChecker
sharedSpellChecker] on the line below.

More information about the webkit-reviews mailing list