[webkit-reviews] review granted: [Bug 89112] Fix bit packing of StyleRareInheritedData on Windows : [Attachment 147614] Patch

[bugzilla-daemon at webkit.org]

Ryosuke Niwa <rniwa at webkit.org> has granted Tony Chang <tony at chromium.org>'s
request for review:
Bug 89112: Fix bit packing of StyleRareInheritedData on Windows
https://bugs.webkit.org/show_bug.cgi?id=89112

Attachment 147614: Patch
https://bugs.webkit.org/attachment.cgi?id=147614&action=review

------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=147614&action=review


> Source/WebCore/rendering/style/StyleRareInheritedData.cpp:44
> +    unsigned m_bitfields[2];
> +
> +    Color colors[6];
> +    float floats[2];
> +    void* ownPtrs[1];
> +    AtomicString atomicStrings[5];
> +    void* refPtrs[2];
> +    Length lengths[1];
> +    short pagedMediaShorts[2];
> +    unsigned unsigneds[1];
> +    short hyphenationShorts[3];

I would be very careful with the order in which these things appear.
e.g.
unsigned a;
void* b;
unsigned c;
and
unsigned a;
unsigned b;
void* c
will consume a different size on a 64-bit architecture.