[webkit-reviews] review granted: [Bug 75825] webkit-patch land should automatically add svn:mime-type for .png files : [Attachment 147528] proposed fix

[bugzilla-daemon at webkit.org]

Dirk Pranke <dpranke at chromium.org> has granted Balazs Ankes
<bank at inf.u-szeged.hu>'s request for review:
Bug 75825: webkit-patch land should automatically add svn:mime-type for .png
files
https://bugs.webkit.org/show_bug.cgi?id=75825

Attachment 147528: proposed fix
https://bugs.webkit.org/attachment.cgi?id=147528&action=review

------- Additional Comments from Dirk Pranke <dpranke at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=147528&action=review


assuming my comments are correct, fix the comments and variable names and this
should be fine.

> Tools/Scripts/webkitpy/common/checksvnconfigfile.py:36
> +    was the file read successful, is there enable the auto-props, is there
enable the svn:mime-type for png

I'm not sure if this is a bug or if this is just written wrong, but it looks
like you want to return True if something failed, right? So I would rewrite
this as "is this file missing, is auto-props missing, is the svn:mime-type for
png missing"

> Tools/Scripts/webkitpy/style/checkers/png.py:58
> +	       (file_read, autoprop, png) = checksvnconfigfile.check(self,
self._host, self._fs)

I would rename these variables the same way I renamed the docstring, so
file_missing, autoprop_missing, png_missing