[webkit-reviews] review denied: [Bug 34608] Deleting text leaves the style of text in the typing style : [Attachment 147558] Proposed Patch

[bugzilla-daemon at webkit.org]

Ryosuke Niwa <rniwa at webkit.org> has denied Pravin D <pravind.2k4 at gmail.com>'s
request for review:
Bug 34608: Deleting text leaves the style of text in the typing style
https://bugs.webkit.org/show_bug.cgi?id=34608

Attachment 147558: Proposed Patch
https://bugs.webkit.org/attachment.cgi?id=147558&action=review

------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=147558&action=review


> Source/WebCore/ChangeLog:10
> +	   Reviewed by NOBODY (OOPS!).

This should appear before the long description but after the bug URL.

> Source/WebCore/editing/FrameSelection.h:244
> +    bool shouldUpdateTypingStyle() { return m_updateTypingStyle; }
> +    void setUpdateTypingStyle(bool v) { m_updateTypingStyle = v; }
> +

I don't think we want to be adding these member functions and variables just
for DeleteSelectionCommand. r-.