[webkit-reviews] review granted: [Bug 89093] Remove volume thumb for videos without audio track for Chrome Video controls : [Attachment 147572] Use this for review

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jun 14 09:49:32 PDT 2012


Eric Carlson <eric.carlson at apple.com> has granted Silvia Pfeiffer
<silviapf at chromium.org>'s request for review:
Bug 89093: Remove volume thumb for videos without audio track for Chrome Video
controls
https://bugs.webkit.org/show_bug.cgi?id=89093

Attachment 147572: Use this for review
https://bugs.webkit.org/attachment.cgi?id=147572&action=review

------- Additional Comments from Eric Carlson <eric.carlson at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=147572&action=review


Looks fine except for the ChangeLog.

> Source/WebCore/ChangeLog:7
>  2012-06-14  Silvia Pfeiffer	<silviapf at chromium.org>
>  
> -	   Add fullscreen button to Chrome video controls for video.
> -	   https://bugs.webkit.org/show_bug.cgi?id=88818
> +	   Remove volume thumb for videos without audio track.
> +	   https://bugs.webkit.org/show_bug.cgi?id=89093
>  
>	   Reviewed by NOBODY (OOPS!).
>  

Clearly something went wrong when this ChangeLog was generated :-)


More information about the webkit-reviews mailing list