[webkit-reviews] review requested: [Bug 88888] RenderLayer subtrees without any self-painting layer shouldn't be walked during painting : [Attachment 147327] Change v4. Fixed the invalidation logic as it wasn't dirtying.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jun 14 08:44:00 PDT 2012


Julien Chaffraix <jchaffraix at webkit.org> has asked  for review:
Bug 88888: RenderLayer subtrees without any self-painting layer shouldn't be
walked during painting
https://bugs.webkit.org/show_bug.cgi?id=88888

Attachment 147327: Change v4. Fixed the invalidation logic as it wasn't
dirtying.
https://bugs.webkit.org/attachment.cgi?id=147327&action=review

------- Additional Comments from Julien Chaffraix <jchaffraix at webkit.org>
I believe the patch is good enough for a review now. The flaw in the logic made
us not dirty anything (thus keeping m_hasSelfPaintingLayerDescendant set) and
the test hit an ASSERT that I fixed so we should have some coverage.


More information about the webkit-reviews mailing list