[webkit-reviews] review granted: [Bug 89101] Web Inspector: refactor settings screen to move user agent and experiments out of general tab. : [Attachment 147583] Patch

[bugzilla-daemon at webkit.org]

Vsevolod Vlasov <vsevik at chromium.org> has granted Pavel Feldman
<pfeldman at chromium.org>'s request for review:
Bug 89101: Web Inspector: refactor settings screen to move user agent and
experiments out of general tab.
https://bugs.webkit.org/show_bug.cgi?id=89101

Attachment 147583: Patch
https://bugs.webkit.org/attachment.cgi?id=147583&action=review

------- Additional Comments from Vsevolod Vlasov <vsevik at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=147583&action=review


> Source/WebCore/inspector/front-end/SettingsScreen.js:46
> +   
this._tabbedPane.headerContentsElement.insertBefore(this._createCloseButton(),
this._tabbedPane.headerContentsElement.firstChild);

After this change it is quite possible that
this._tabbedPane.headerContentsElement.offsetWidth is not big enough for all
tabs.
Consider setting shrinkableTabs on tabbedPane and making sure all necessary
resize/calculations are done properly.