[webkit-reviews] review denied: [Bug 88980] [Forms] Move search field related code to RenderSearchField from RenderTextControlSingleLine : [Attachment 147545] Patch 2

[bugzilla-daemon at webkit.org]

Kent Tamura <tkent at chromium.org> has denied yosin at chromium.org's request for
review:
Bug 88980: [Forms] Move search field related code to RenderSearchField from
RenderTextControlSingleLine
https://bugs.webkit.org/show_bug.cgi?id=88980

Attachment 147545: Patch 2
https://bugs.webkit.org/attachment.cgi?id=147545&action=review

------- Additional Comments from Kent Tamura <tkent at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=147545&action=review


> Source/WebCore/html/HTMLInputElement.cpp:53
> +#include "RenderSearchField.h"

Using RenderSearchField in HTMLInputElement.cpp is not good.
We should move such code to SearchInputType.

> Source/WebCore/html/TextFieldInputType.cpp:203
>  RenderObject* TextFieldInputType::createRenderer(RenderArena* arena,
RenderStyle*) const
>  {
> -    return new (arena) RenderTextControlSingleLine(element());
> +    return isSearchField() ? new (arena) RenderSearchField(element()) : new
(arena) RenderTextControlSingleLine(element());

Should introduce SearchInputType::createRenderer().