[webkit-reviews] review requested: [Bug 78864] Register fixed position layers with ScrollingCoordinator : [Attachment 147557] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Jun 14 05:06:55 PDT 2012
Sami Kyostila <skyostil at google.com> has asked for review:
Bug 78864: Register fixed position layers with ScrollingCoordinator
https://bugs.webkit.org/show_bug.cgi?id=78864
Attachment 147557: Patch
https://bugs.webkit.org/attachment.cgi?id=147557&action=review
------- Additional Comments from Sami Kyostila <skyostil at google.com>
- Renamed setLayerIsFixedToContainerLayerVisibleRect =>
setLayerIsFixedToContainerLayer.
- Fixed layout test failure. Also setNeedsCommit() when a layer's container bit
changes, but only if there are fixed positioned descendants to avoid breaking
the same test.
- Use hasLayer() instead of downcast + layer().
More information about the webkit-reviews
mailing list