[webkit-reviews] review requested: [Bug 88838] Delete Grammar markers on editing : [Attachment 147523] Patch v2 (applied comments and updated description)
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Jun 14 02:05:11 PDT 2012
Hironori Bono <hbono at chromium.org> has asked for review:
Bug 88838: Delete Grammar markers on editing
https://bugs.webkit.org/show_bug.cgi?id=88838
Attachment 147523: Patch v2 (applied comments and updated description)
https://bugs.webkit.org/attachment.cgi?id=147523&action=review
------- Additional Comments from Hironori Bono <hbono at chromium.org>
Greetings Niwa-san,
Thanks for your review and comments. While reading your comments, I notice I
just like to allow the WebKit layer to decide whether to delete markers in
Editor::updateMarkersForWordsAffectedByEditing(). (I got confused while
integrating grammar checkers to EditorClientImpl::checkGrammarOfString().) Even
though I have applied all of your comments, it would be definitely helpful to
shoot me if this change still has problems.
Regards,
Hironori Bono
More information about the webkit-reviews
mailing list