[webkit-reviews] review granted: [Bug 89070] [JSC/V8] Improve DOMString[] support : [Attachment 147512] Patch 2

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jun 14 01:09:47 PDT 2012


Kentaro Hara <haraken at chromium.org> has granted Kent Tamura
<tkent at chromium.org>'s request for review:
Bug 89070: [JSC/V8] Improve DOMString[] support
https://bugs.webkit.org/show_bug.cgi?id=89070

Attachment 147512: Patch 2
https://bugs.webkit.org/attachment.cgi?id=147512&action=review

------- Additional Comments from Kentaro Hara <haraken at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=147512&action=review


Looks reasonable to me too.

> Source/WebCore/bindings/js/JSDOMBinding.cpp:153
> +    if (!stringList)
> +	   return jsUndefined();

Just a confirmation: You are intending to return (not [] but) undefined for a
null stringList, right?


More information about the webkit-reviews mailing list