[webkit-reviews] review denied: [Bug 87844] Implement painting slider tick marks : [Attachment 147470] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Jun 13 20:13:31 PDT 2012
Kent Tamura <tkent at chromium.org> has denied Keishi Hattori
<keishi at webkit.org>'s request for review:
Bug 87844: Implement painting slider tick marks
https://bugs.webkit.org/show_bug.cgi?id=87844
Attachment 147470: Patch
https://bugs.webkit.org/attachment.cgi?id=147470&action=review
------- Additional Comments from Kent Tamura <tkent at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=147470&action=review
> Source/WebCore/css/html.css:573
> + color: #909090;
Let's make a separated patch to update html.css, themeChromiumLinux.css, and
themeWin.css.
> Source/WebCore/rendering/RenderTheme.cpp:972
> +IntSize RenderTheme::sliderTickSize() const
> +{
> + return IntSize(1, 1);
> +}
> +
> +int RenderTheme::sliderTickOffsetFromTrackCenter() const
> +{
> + return 0;
> +}
Remove them. These default implementations are useless.
> Source/WebCore/rendering/RenderTheme.cpp:993
> + RenderObject* thumbRenderer =
input->shadow()->oldestShadowRoot()->firstChild()->firstChild()->firstChild()->
renderer();
We had better have a helper function to get a thumb element.
> Source/WebCore/rendering/RenderTheme.h:220
> + // Returns size of one slider tick mark for a horizontal track.
> + virtual IntSize sliderTickSize() const;
> + // Returns the distance of slider tick origin from the slider track
center.
> + virtual int sliderTickOffsetFromTrackCenter() const;
Make them pure virtual.
Also, we need a comment for sliderTickSize about rotation for vertical sliders.
> Source/WebCore/rendering/RenderTheme.h:221
> + virtual void paintSliderTicks(RenderObject*, const PaintInfo&, const
IntRect&);
This can be non-virtual.
More information about the webkit-reviews
mailing list