[webkit-reviews] review denied: [Bug 87973] [GTK] Implement disableImageLoading in DRT : [Attachment 147428] patch proposal

[bugzilla-daemon at webkit.org]

Martin Robinson <mrobinson at webkit.org> has denied arno. <arno at renevier.net>'s
request for review:
Bug 87973: [GTK] Implement disableImageLoading in DRT
https://bugs.webkit.org/show_bug.cgi?id=87973

Attachment 147428: patch proposal
https://bugs.webkit.org/attachment.cgi?id=147428&action=review

------- Additional Comments from Martin Robinson <mrobinson at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=147428&action=review


Seems sane though there are a few things that look off:

> Tools/DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:453
>      // FIXME: Implement for testing fix for
https://bugs.webkit.org/show_bug.cgi?id=27896
>      // Also need to make sure image loading is re-enabled for each new test.


It'd make sense to remove this comment now.

> LayoutTests/ChangeLog:6
> +	   [GTK] Implement disableImageLoading in DRT
> +	   Add TEXT expectation to
favicon-loads-with-icon-loading-override.html
> +	   which was only working by accident.
> +	   https://bugs.webkit.org/show_bug.cgi?id=87973

Your changelog looks a little funky here. The description should go below the
"Reviewed by" line.

> LayoutTests/platform/gtk/TestExpectations:1293
> +BUGWKGTK   : http/tests/misc/favicon-loads-with-icon-loading-override.html =
TEXT

It seems you are replacing an existing failure with another?