[webkit-reviews] review granted: [Bug 88972] [chromium] Implement hit-testing for impl-side input handling in accelerated compositor : [Attachment 147425] Avoids visibleLayerRect problems and quad limitations

[bugzilla-daemon at webkit.org]

Adrienne Walker <enne at google.com> has granted Shawn Singh
<shawnsingh at chromium.org>'s request for review:
Bug 88972: [chromium] Implement hit-testing for impl-side input handling in
accelerated compositor
https://bugs.webkit.org/show_bug.cgi?id=88972

Attachment 147425: Avoids visibleLayerRect problems and quad limitations
https://bugs.webkit.org/attachment.cgi?id=147425&action=review

------- Additional Comments from Adrienne Walker <enne at google.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=147425&action=review


R=me.  So many tests! :)

> Source/WebCore/platform/graphics/chromium/cc/CCLayerTreeHostCommon.cpp:884
> +    // Note: its possible to compute the hit test in two equivalent ways:
> +    //    inverse-project the point into local space
> +    //    forward-transform the rect to screen space
> +    //
> +    // Its not obvious which one would perform better, or which one would be
more robust
> +    // to w < 0 homogeneous clipping issues. For now, we simply opt for the
inverse-project
> +    // approach.
> +    //

s/its/it's/g

Also, I don't know if you need this big block comment here.  There's different
ways to implement nearly everything, but there's no need to necessarily
document that.	If you want to explain your reasoning, it might make more sense
as a commit message.