[webkit-reviews] review granted: [Bug 89030] el.getAttribute('type') returns 'null' when setting el.type to null : [Attachment 147424] Proposed fix and updated tests.
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Jun 13 15:42:50 PDT 2012
Alexey Proskuryakov <ap at webkit.org> has granted Edaena Salinas
<edaena at gmail.com>'s request for review:
Bug 89030: el.getAttribute('type') returns 'null' when setting el.type to null
https://bugs.webkit.org/show_bug.cgi?id=89030
Attachment 147424: Proposed fix and updated tests.
https://bugs.webkit.org/attachment.cgi?id=147424&action=review
------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
+ Reviewed by NOBODY (OOPS!).
For minor changes like these, you could have edited ChangeLogs to say "Reviewed
by Darin Adler", and post a new patch with "commit-queue?" flag alone, no
"review?" flag.
+ (HTMLButtonElement): Changed parameter to be AtomicString to address
an unrelated
+ review comment from bug 14439 for slightly better performance.
We traditionally just say "Ditto" for repeated comments.
More information about the webkit-reviews
mailing list