[webkit-reviews] review granted: [Bug 89030] el.getAttribute('type') returns 'null' when setting el.type to null : [Attachment 147413] Proposed fix and updated tests.

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Edaena Salinas <edaena at gmail.com>'s
request for review:
Bug 89030: el.getAttribute('type') returns 'null' when setting el.type to null
https://bugs.webkit.org/show_bug.cgi?id=89030

Attachment 147413: Proposed fix and updated tests.
https://bugs.webkit.org/attachment.cgi?id=147413&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=147413&action=review


>> LayoutTests/fast/dom/HTMLButtonElement/change-type.html:64
>>	shouldBe("btn.getAttribute('type')", "undefined + ''");
> 
> As you are addressing unrelated feedback, you can consider changing this to
"'undefined'", too.

I agree, you should do that.