[webkit-reviews] review denied: [Bug 88936] StringImpl::characters can return NULL for an empty string : [Attachment 147410] Patch

[bugzilla-daemon at webkit.org]

Ryosuke Niwa <rniwa at webkit.org> has denied Myles C. Maxfield
<mmaxfield at google.com>'s request for review:
Bug 88936: StringImpl::characters can return NULL for an empty string
https://bugs.webkit.org/show_bug.cgi?id=88936

Attachment 147410: Patch
https://bugs.webkit.org/attachment.cgi?id=147410&action=review

------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=147410&action=review


> Source/WTF/wtf/unicode/icu/CollatorICU.cpp:106
> +    if (!lhs && !lhsLength)
> +	 lhs = (const UChar*)1;
> +    if (!rhs && !rhsLength)
> +	 rhs = (const UChar*)1;

Please use "" here instead.  I don't see any value in using a made up pointer
value like 1.