[webkit-reviews] review denied: [Bug 88121] [chromium] Support high DIP pixel tests with DumpRenderTree : [Attachment 147400] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jun 13 14:04:08 PDT 2012


James Robinson <jamesr at chromium.org> has denied  review:
Bug 88121: [chromium] Support high DIP pixel tests with DumpRenderTree
https://bugs.webkit.org/show_bug.cgi?id=88121

Attachment 147400: Patch
https://bugs.webkit.org/attachment.cgi?id=147400&action=review

------- Additional Comments from James Robinson <jamesr at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=147400&action=review


> Source/WebKit/chromium/public/WebWidget.h:99
> +    virtual void paint(WebCanvas*, const WebRect& viewPort, const int
scaleFactor = 1) { }

this seems misguided.  We already have a deviceScaleFactor and pageScaleFactor
setter on WebView, why are they not sufficient?


More information about the webkit-reviews mailing list