[webkit-reviews] review granted: [Bug 81974] Adds color management support to Chromium port. : [Attachment 147395] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jun 13 13:20:40 PDT 2012


Adam Barth <abarth at webkit.org> has granted Tony Payne <tpayne at chromium.org>'s
request for review:
Bug 81974: Adds color management support to Chromium port.
https://bugs.webkit.org/show_bug.cgi?id=81974

Attachment 147395: Patch
https://bugs.webkit.org/attachment.cgi?id=147395&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=147395&action=review


> Source/WebCore/platform/image-decoders/ImageDecoder.h:307
> +	       if (!qcmsInitialized) {

I would have put the body of branch out-of-line since it's kind of silly to
inline it into each call site.


More information about the webkit-reviews mailing list