[webkit-reviews] review denied: [Bug 88820] Padding and borders can cause integer overflow in block layouts : [Attachment 147398] Patch

[bugzilla-daemon at webkit.org]

Tony Chang <tony at chromium.org> has denied Jeffrey Pfau <jeffrey at endrift.com>'s
request for review:
Bug 88820: Padding and borders can cause integer overflow in block layouts
https://bugs.webkit.org/show_bug.cgi?id=88820

Attachment 147398: Patch
https://bugs.webkit.org/attachment.cgi?id=147398&action=review

------- Additional Comments from Tony Chang <tony at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=147398&action=review


> Source/WebCore/rendering/AutoTableLayout.cpp:224
> +// Use a very large value (in effect infinite). But not too large!
> +// Keep this in synch with BLOCK_MAX_WIDTH in RenderBlock.cpp and
TABLE_MAX_WIDTH in FixedTableLayout.cpp
> +#define TABLE_MAX_WIDTH 15000

Can you remove BLOCK_MAX_WIDTH from RenderBlock.cpp?  It doesn't look like it's
used anymore.  Then you can update the comment here and in
FixedTableLayout.cpp.  We might just want to somehow share the value between
FixedTableLayout.cpp and AutoTableLayout.cpp (maybe declare a static in
TableLayout.h and instantiate it in RenderTable.cpp?), but that seems less
important.