[webkit-reviews] review denied: [Bug 88931] some headers are included twice in WebCore : [Attachment 147179] patch proposal

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jun 13 12:45:24 PDT 2012

Rob Buis <rwlbuis at gmail.com> has denied arno. <arno at renevier.net>'s request for
Bug 88931: some headers are included twice in WebCore

Attachment 147179: patch proposal

------- Additional Comments from Rob Buis <rwlbuis at gmail.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=147179&action=review

Looks good, but you should try to remove the one so not to make the sorting
worse. Also r- based on Adam's comment.

> Source/WebCore/rendering/InlineFlowBox.cpp:-39
> -#include "RootInlineBox.h"

I think you should remove the first occurrence of it, otherwise you violate (or
keep violating) the alphabetic sorting rule.

More information about the webkit-reviews mailing list