[webkit-reviews] review requested: [Bug 73350] [chromium] Allow scrolling non-root layers in the compositor thread : [Attachment 147383] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jun 13 12:07:48 PDT 2012


Sami Kyostila <skyostil at google.com> has asked  for review:
Bug 73350: [chromium] Allow scrolling non-root layers in the compositor thread
https://bugs.webkit.org/show_bug.cgi?id=73350

Attachment 147383: Patch
https://bugs.webkit.org/attachment.cgi?id=147383&action=review

------- Additional Comments from Sami Kyostila <skyostil at google.com>
This patch incorporates all the review feedback so far *except* for the
extracted hit testing function since that is still being finalized.

- Added a dedicated scroll delegate to LayerChromium.
- Use cc component for tracing.
- Only hit test against self-representing layers.
- Renamed releaseRootLayer() to detachLayerTree()
- Instead of separating renderSurfaceLayerList from FrameData, made FrameData
refcounted so CCLayerTreeHostImpl can cache the most recent one.


More information about the webkit-reviews mailing list