[webkit-reviews] review denied: [Bug 88326] [BlackBerry] [DRT] DRT should be able to run interactively and support multiple processes : [Attachment 145995] Git patch

[bugzilla-daemon at webkit.org]

Rob Buis <rwlbuis at gmail.com> has denied Xiaobo Wang
<xiaobo.wang at torchmobile.com.cn>'s request for review:
Bug 88326: [BlackBerry] [DRT] DRT should be able to run interactively and
support multiple processes
https://bugs.webkit.org/show_bug.cgi?id=88326

Attachment 145995: Git patch
https://bugs.webkit.org/attachment.cgi?id=145995&action=review

------- Additional Comments from Rob Buis <rwlbuis at gmail.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=145995&action=review


Looks good, can maybe be cleaned up some more, also judging from Ming's
comment.

> Tools/DumpRenderTree/blackberry/DumpRenderTree.cpp:344
> +		   S_IROTH | S_IWOTH);

I think alignment could be a bit better here, more can be put onto one line.

> Tools/DumpRenderTree/blackberry/DumpRenderTree.cpp:354
> +    const int lenTestFile = 11;

Better to not hardcode this I think.