[webkit-reviews] review granted: [Bug 88945] webkitpy: rework the TestExpectations style checker in preparation for the cascade : [Attachment 147216] Patch

[bugzilla-daemon at webkit.org]

Ojan Vafai <ojan at chromium.org> has granted Dirk Pranke <dpranke at chromium.org>'s
request for review:
Bug 88945: webkitpy: rework the TestExpectations style checker in preparation
for the cascade
https://bugs.webkit.org/show_bug.cgi?id=88945

Attachment 147216: Patch
https://bugs.webkit.org/attachment.cgi?id=147216&action=review

------- Additional Comments from Ojan Vafai <ojan at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=147216&action=review


> Tools/Scripts/webkitpy/style/checkers/test_expectations.py:82
> +	   expectations = parser.parse('expectations', expectations_str)
> +	   if overrides:
> +	       expectations += parser.parse('overrides', overrides)

This should have a FIXME to handle cascading expectations properly.

I think each style error line should probably print out the file the style
error is in.