[webkit-reviews] review granted: [Bug 88947] nrwt: implement the actual cascade of TestExpectations : [Attachment 147218] Patch

[bugzilla-daemon at webkit.org]

Ojan Vafai <ojan at chromium.org> has granted Dirk Pranke <dpranke at chromium.org>'s
request for review:
Bug 88947: nrwt: implement the actual cascade of TestExpectations
https://bugs.webkit.org/show_bug.cgi?id=88947

Attachment 147218: Patch
https://bugs.webkit.org/attachment.cgi?id=147218&action=review

------- Additional Comments from Ojan Vafai <ojan at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=147218&action=review


> Tools/ChangeLog:15
> +	   There is an actual semantic change in this patch, in that
> +	   setting an expectation on a directory in one file will override
> +	   the expectations on any individual tests set in prior files. The
> +	   test_overrides__directory() unit test verifies this.

I really think we should simplify the logic of test_expectations entirely (in a
separate patch obviously) to last one wins. Even within the same expectations
file. The "more specific wins" is more confusing than the benefit it brings.

> Tools/Scripts/webkitpy/layout_tests/models/test_expectations.py:597
> +	   if prev_expectation_line.filename != expectation_line.filename:

Clever!