[webkit-reviews] review granted: [Bug 88946] webkitpy: update callers to use port.expectation_dict() instead of test_expectations() and test_expectations_overrides() : [Attachment 147217] Patch

[bugzilla-daemon at webkit.org]

Ojan Vafai <ojan at chromium.org> has granted Dirk Pranke <dpranke at chromium.org>'s
request for review:
Bug 88946: webkitpy: update callers to use port.expectation_dict() instead of
test_expectations() and test_expectations_overrides()
https://bugs.webkit.org/show_bug.cgi?id=88946

Attachment 147217: Patch
https://bugs.webkit.org/attachment.cgi?id=147217&action=review

------- Additional Comments from Ojan Vafai <ojan at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=147217&action=review


> Tools/Scripts/webkitpy/layout_tests/models/test_expectations.py:764
> +	   if len(expectations_dict) > 1 and include_overrides:

Side nit: why do we even have an include_overrides boolean? It seems like this
should go away, esp as we're adding cascading.