[webkit-reviews] review granted: [Bug 88942] nrwt: preliminary cleanup before supporting cascading expectations files : [Attachment 147212] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jun 13 09:26:40 PDT 2012


Ojan Vafai <ojan at chromium.org> has granted Dirk Pranke <dpranke at chromium.org>'s
request for review:
Bug 88942: nrwt: preliminary cleanup before supporting cascading expectations
files
https://bugs.webkit.org/show_bug.cgi?id=88942

Attachment 147212: Patch
https://bugs.webkit.org/attachment.cgi?id=147212&action=review

------- Additional Comments from Ojan Vafai <ojan at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=147212&action=review


> Tools/Scripts/webkitpy/layout_tests/models/test_expectations.py:239
> +	   expectation_line.filename = '<Skipped file>'

Should this have a FIXME to associate paths with Skipped file lines as well? I
doubt we'll ever get around to it as we'll hopefully drop Skipped files
entirely.


More information about the webkit-reviews mailing list