[webkit-reviews] review denied: [Bug 87790] WTF TCSpinLock.h doesn't compile for x64 with Visual Studio : [Attachment 145821] Patch

[bugzilla-daemon at webkit.org]

Brent Fulgham <bfulgham at webkit.org> has denied Alex Christensen
<alex.christensen at flexsim.com>'s request for review:
Bug 87790: WTF TCSpinLock.h doesn't compile for x64 with Visual Studio
https://bugs.webkit.org/show_bug.cgi?id=87790

Attachment 145821: Patch
https://bugs.webkit.org/attachment.cgi?id=145821&action=review

------- Additional Comments from Brent Fulgham <bfulgham at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=145821&action=review


Thanks for looking into this!  I have a couple of minor requests, otherwise
this looks great.

> Source/WTF/ChangeLog:8
> +	   * wtf/TCSpinLock.h:

Please state here that you modified the test for MSVC suitability.

> Source/WTF/wtf/TCSpinLock.h:-37
> -#if (CPU(X86) || CPU(X86_64) || CPU(PPC)) && (COMPILER(GCC) ||
COMPILER(MSVC))

I don't care for the reformatting of these tests, since it loses the
distinction between architecture and compiler.

I would prefer to see something along the lines of:
#if ((CPU(X86) || CPU(X86_64) || CPU(PPC)) && COMPILER(GCC)) || (CPU(X86) &&
COMPILER(MSVC))