[webkit-reviews] review granted: [Bug 88706] Web Inspector: Support user attributes in DOMNode : [Attachment 147307] Patch

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has granted Alexander Pavlov (apavlov)
<apavlov at chromium.org>'s request for review:
Bug 88706: Web Inspector: Support user attributes in DOMNode
https://bugs.webkit.org/show_bug.cgi?id=88706

Attachment 147307: Patch
https://bugs.webkit.org/attachment.cgi?id=147307&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=147307&action=review


> Source/WebCore/inspector/front-end/DOMAgent.js:707
> +    setUserAttribute: function(name, value)

setUserProperty ?

> Source/WebCore/inspector/front-end/DOMAgent.js:712
> +	       var didHaveAttribute = this._userAttributes[name] !== null &&
this._userAttributes[name] !== undefined && this._userAttributes[name] !==
false;

Lets clear on "null" only

> Source/WebCore/inspector/front-end/DOMAgent.js:718
> +	   if (nowHaveAttribute)

This looks weird, I would extract "remove" method

> Source/WebCore/inspector/front-end/DOMAgent.js:731
> +	   return this._descendantUserAttributeCounters &&
this._descendantUserAttributeCounters[name] ?
this._descendantUserAttributeCounters[name] : 0;

I think this._descendantUserAttributeCounters can exist at all times.