[webkit-reviews] review denied: [Bug 87672] [Qt] Add quirks for running the web process in a profiler shell, like valgrind : [Attachment 147087] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Jun 13 07:22:33 PDT 2012
Tor Arne Vestbø <vestbo at webkit.org> has denied Balazs Kelemen
<kbalazs at webkit.org>'s request for review:
Bug 87672: [Qt] Add quirks for running the web process in a profiler shell,
like valgrind
https://bugs.webkit.org/show_bug.cgi?id=87672
Attachment 147087: Patch
https://bugs.webkit.org/attachment.cgi?id=147087&action=review
------- Additional Comments from Tor Arne Vestbø <vestbo at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=147087&action=review
> Tools/WebKitTestRunner/TestController.cpp:569
> + if (!m_useRensponsivityTimer) {
> + platformRunUntil(done, m_noTimeout);
> + return;
> + }
> +
Why don't we just call runUntil() with NoTimeout ?
More information about the webkit-reviews
mailing list