[webkit-reviews] review granted: [Bug 64966] [svg] SVGResources applied to Text with Incorrect Transformations in non-CG Implementations : [Attachment 146834] Patch v5, gradient test case simplified.

[bugzilla-daemon at webkit.org]

Nikolas Zimmermann <zimmermann at kde.org> has granted Dominik Röttsches (drott)
<dominik.rottsches at intel.com>'s request for review:
Bug 64966: [svg] SVGResources applied to Text with Incorrect Transformations in
non-CG Implementations
https://bugs.webkit.org/show_bug.cgi?id=64966

Attachment 146834: Patch v5, gradient test case simplified.
https://bugs.webkit.org/attachment.cgi?id=146834&action=review

------- Additional Comments from Nikolas Zimmermann <zimmermann at kde.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=146834&action=review


Sorry, seems I forgot to submit them, I actually reviewed this yesterday :(
Anyhow, r=me, but please update platform/chromium/test_expectations.txt so that
cr-linux doesn't turn red of you land this.
Mark the failing tests as IMAGE IMAGE+TEXT TEXT etc..

> Source/WebCore/rendering/svg/RenderSVGResourceContainer.cpp:27
> +#if !USE(CG)
> +#include....

I think you can always include the file.

> Source/WebCore/rendering/svg/RenderSVGResourceContainer.cpp:183
> +#if USE(CG)
> +    UNUSED_PARAM(object);
> +    UNUSED_PARAM(resourceTransform);
> +    return false;
> +#else
> +    ASSERT(object);

Use ASSERT_UNUSED(object, object) to avoid branching UNUSED_PARAM vs. ASSERT
for 'object'.