[webkit-reviews] review granted: [Bug 88902] Web Inspector: add a way to get the remote inspector url for a given page. : [Attachment 147299] Patch

[bugzilla-daemon at webkit.org]

Jocelyn Turcotte <jocelyn.turcotte at nokia.com> has granted Alexis Menard
(darktears) <alexis.menard at openbossa.org>'s request for review:
Bug 88902: Web Inspector: add a way to get the remote inspector url for a given
page.
https://bugs.webkit.org/show_bug.cgi?id=88902

Attachment 147299: Patch
https://bugs.webkit.org/attachment.cgi?id=147299&action=review

------- Additional Comments from Jocelyn Turcotte <jocelyn.turcotte at nokia.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=147299&action=review


Only one detail, looks awesome otherwise.

> Source/WebKit2/UIProcess/InspectorServer/WebSocketServer.cpp:71
> +    } else
> +	   m_state = Closed;

Because we return early if m_state == Listening you can omit that part. That
wasn't needed in the original code either :P