[webkit-reviews] review granted: [Bug 88865] [Qt] Handle multiple held buttons in touch mocking. : [Attachment 147079] Fix holding released buttons
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Jun 13 05:26:05 PDT 2012
Kenneth Rohde Christiansen <kenneth at webkit.org> has granted Allan Sandfeld
Jensen <allan.jensen at nokia.com>'s request for review:
Bug 88865: [Qt] Handle multiple held buttons in touch mocking.
https://bugs.webkit.org/show_bug.cgi?id=88865
Attachment 147079: Fix holding released buttons
https://bugs.webkit.org/attachment.cgi?id=147079&action=review
------- Additional Comments from Kenneth Rohde Christiansen
<kenneth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=147079&action=review
> Tools/MiniBrowser/qt/MiniBrowserApplication.cpp:149
> + if (mouseEvent->buttons() > mouseEvent->button())
Migth deserve a comment
> Tools/MiniBrowser/qt/MiniBrowserApplication.cpp:180
> + // A move can have resulted in multiple buttons, so we need check
them out individually.
I would remove 'out'
More information about the webkit-reviews
mailing list