[webkit-reviews] review granted: [Bug 87749] [WK2][Qt] Color chooser API missing : [Attachment 147286] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jun 13 04:36:54 PDT 2012


Kenneth Rohde Christiansen <kenneth at webkit.org> has granted Thiago Marcos P.
Santos <tmpsantos at gmail.com>'s request for review:
Bug 87749: [WK2][Qt] Color chooser API missing
https://bugs.webkit.org/show_bug.cgi?id=87749

Attachment 147286: Patch
https://bugs.webkit.org/attachment.cgi?id=147286&action=review

------- Additional Comments from Kenneth Rohde Christiansen
<kenneth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=147286&action=review


Can we have a tesT?

> Source/WebKit2/UIProcess/API/qt/qquickwebview.cpp:1158
> +    if (d->colorChooser == colorChooser)
> +	   return;

we normally add newline after return


More information about the webkit-reviews mailing list