[webkit-reviews] review requested: [Bug 88838] Delete Grammar markers on editing : [Attachment 147272] Patch v1

[bugzilla-daemon at webkit.org]

Hironori Bono <hbono at chromium.org> has asked  for review:
Bug 88838: Delete Grammar markers on editing
https://bugs.webkit.org/show_bug.cgi?id=88838

Attachment 147272: Patch v1
https://bugs.webkit.org/attachment.cgi?id=147272&action=review

------- Additional Comments from Hironori Bono <hbono at chromium.org>
Greetings,

While investigating layout-test errors, I notice it may be better to call
TextCheckClient::shouldEraseMarkersAfterChangeSelection() in
Editor::updateMarkersForWordsAffectedByEditing() instead of setting
WTF_USE_MARKER_REMOVAL_UPON_EDITING to 1. (We need to delete markers on editing
only when this function returns false. If this function returns true, WebKit
removes markers when we start editing grammatically-incorrect words.)

Regards,

Hironori Bono