[webkit-reviews] review granted: [Bug 88955] Editing tests should use testRunner instead of layoutTestController : [Attachment 147224] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jun 12 23:01:46 PDT 2012

Darin Adler <darin at apple.com> has granted Ryosuke Niwa <rniwa at webkit.org>'s
request for review:
Bug 88955: Editing tests should use testRunner instead of layoutTestController

Attachment 147224: Patch

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=147224&action=review


Not sure why the pasteboard data is showing up in the diff. Doesn't seem right
to change that.

> LayoutTests/editing/deleting/2610675-3.html:18
> +    window.testRunner.dumpAsText();

Some day I think I’ll go take out all the "window." prefixes on lines like this

> LayoutTests/editing/deleting/2610675-3.html:20
>  window.getSelection().setPosition(blockquote, 0);

And lines like this one.

> LayoutTests/editing/selection/paragraph-granularity.html:37
> +<p style="color:green">This test does not run interactively.  It uses the
testRunners eventSender to do mouse clicks.  To run it manually, double click
on the blue 'g', then drag down to the red 'g'.  As you drag, watch the
selection that is created, it should always start and end on paragraph

Not great grammar here. Should be "the testRunner's eventSender" or, if it was
me, "the test runner's event sender".

More information about the webkit-reviews mailing list