[webkit-reviews] review denied: [Bug 84532] [Qt][WK2] Private non-QtQuick API : [Attachment 147208] patch

[bugzilla-daemon at webkit.org]

Noam Rosenthal <noam.rosenthal at nokia.com> has denied Luiz Agostini
<luiz at webkit.org>'s request for review:
Bug 84532: [Qt][WK2] Private non-QtQuick API
https://bugs.webkit.org/show_bug.cgi?id=84532

Attachment 147208: patch
https://bugs.webkit.org/attachment.cgi?id=147208&action=review

------- Additional Comments from Noam Rosenthal <noam.rosenthal at nokia.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=147208&action=review


> Source/WebKit2/ChangeLog:10
> +	   This is not public API. It may change without notice at any time
> +	   in future and we make no commitment regarding source compatibility
> +	   or binary compatibility.

This warning should be in the header file, the changelog should describe what
the API actually does.

> Source/WebKit2/Target.pri:180
> +    UIProcess/API/cpp/qt/QWKView_p.h \
> +    UIProcess/API/cpp/qt/QWKView_p_p.h \

Probably needs to be qwkview_p and qwkview_p_p.

> Source/WebKit2/UIProcess/API/cpp/qt/QWKView.cpp:96
> +	   return;
> +
> +

Extra line

> Source/WebKit2/UIProcess/API/cpp/qt/QWKView.cpp:98
> +   
drawingArea->setVisibleContentsRect(WebCore::IntRect(WebCore::IntPoint(),
m_size), 1, WebCore::FloatPoint());

What does 1 mean? Needs a comment

> Source/WebKit2/UIProcess/API/cpp/qt/QWKView.cpp:116
> +    renderer->setVisibleContentsRect(WebCore::IntRect(WebCore::IntPoint(),
m_size), 1, WebCore::FloatPoint());

ditto