[webkit-reviews] review denied: [Bug 88344] Fix FastMalloc.cpp compile error for MSVC in 64-bit : [Attachment 147167] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jun 12 18:37:27 PDT 2012


Ryosuke Niwa <rniwa at webkit.org> has denied Alex Christensen
<alex.christensen at flexsim.com>'s request for review:
Bug 88344: Fix FastMalloc.cpp compile error for MSVC in 64-bit
https://bugs.webkit.org/show_bug.cgi?id=88344

Attachment 147167: Patch
https://bugs.webkit.org/attachment.cgi?id=147167&action=review

------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=147167&action=review


> Source/WTF/wtf/FastMalloc.cpp:2489
> +static TCMalloc_Central_FreeListPadded<(64 -
(sizeof(TCMalloc_Central_FreeList) % 64)) % 64> central_cache[kNumClasses];

Oh, you should probably put this back in struct and just pass sizeof as the
argument.
Aldo, please typedef it so that users of this type doesn't need to know the
trick we're using.


More information about the webkit-reviews mailing list