[webkit-reviews] review granted: [Bug 83526] [V8] IndexedDB: Cursor value modifications should be preserved until cursor iterates : [Attachment 147113] Patch

[bugzilla-daemon at webkit.org]

Kentaro Hara <haraken at chromium.org> has granted Alec Flett
<alecflett at chromium.org>'s request for review:
Bug 83526: [V8] IndexedDB: Cursor value modifications should be preserved until
cursor iterates
https://bugs.webkit.org/show_bug.cgi?id=83526

Attachment 147113: Patch
https://bugs.webkit.org/attachment.cgi?id=147113&action=review

------- Additional Comments from Kentaro Hara <haraken at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=147113&action=review


Looks OK except for nits.

> Source/WebCore/WebCore.gypi:1884
> +	       'bindings/v8/IDBCustomBindings.cpp',

Is this correct? IDBCustomBindings.cpp is added twice.

> LayoutTests/storage/indexeddb/resources/cursor-value.js:56
> +	       index += 2;
> +	   } else if (index == 3) {

Nit: why are you using index+=2 instead of index++?