[webkit-reviews] review requested: [Bug 14439] Can't set el.type on a <button> element : [Attachment 147172] Proposed fix and tests.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jun 12 14:59:35 PDT 2012

Edaena Salinas <edaena at gmail.com> has asked  for review:
Bug 14439: Can't set el.type on a <button> element

Attachment 147172: Proposed fix and tests.

------- Additional Comments from Edaena Salinas <edaena at gmail.com>
I am not sure about the behavior of getAttribute('type') since it is not
returning the same value as el.type. It does not return a lowercase valid value
or an invalid value reseted to 'submit'.  

In addition, when setting btn.type = null, btn.getAttribute('type') returns ''
in Firefox. In WebKit it returns null + '' (null of type string).  Because of
this, the corresponding test will fail in Firefox.

More information about the webkit-reviews mailing list