[webkit-reviews] review granted: [Bug 87068] Replaced items in a flexbox should be coerced to display:block : [Attachment 147143] Patch

[bugzilla-daemon at webkit.org]

Ojan Vafai <ojan at chromium.org> has granted Tony Chang <tony at chromium.org>'s
request for review:
Bug 87068: Replaced items in a flexbox should be coerced to display:block
https://bugs.webkit.org/show_bug.cgi?id=87068

Attachment 147143: Patch
https://bugs.webkit.org/attachment.cgi?id=147143&action=review

------- Additional Comments from Ojan Vafai <ojan at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=147143&action=review


> Source/WebCore/css/StyleResolver.cpp:1923
> +static bool shouldBecomeBlockWhenParentIsFlexbox(const Element* element)

This should probably include a link to the spec.

> LayoutTests/css3/flexbox/resources/flexbox.js:69
> +    var expectedDisplay = node.getAttribute &&
node.getAttribute("data-display");

Nit: should the attribute name be data-expected-display?