[webkit-reviews] review granted: [Bug 88597] [chromium] Port Canvas2DLayerBridge over to WebExternalTextureLayer : [Attachment 146984] rebased and fleshed out ChangeLogs

[bugzilla-daemon at webkit.org]

Adrienne Walker <enne at google.com> has granted James Robinson
<jamesr at chromium.org>'s request for review:
Bug 88597: [chromium] Port Canvas2DLayerBridge over to WebExternalTextureLayer
https://bugs.webkit.org/show_bug.cgi?id=88597

Attachment 146984: rebased and fleshed out ChangeLogs
https://bugs.webkit.org/attachment.cgi?id=146984&action=review

------- Additional Comments from Adrienne Walker <enne at google.com>
(In reply to comment #5)
> (In reply to comment #4)
> > (From update of attachment 146984 [details] [details])
> > View in context:
https://bugs.webkit.org/attachment.cgi?id=146984&action=review
> > 
> > > Source/WebKit/chromium/tests/Canvas2DLayerBridgeTest.cpp:-117
> > > - 	   EXPECT_CALL(implMock, flush());
> > 
> > Why remove the implMock expectations?
> 
> The flush this mock was checking for was coming from the updater's
implementation.  The test no longer verifies the updater's implementation, it
mocks the updater itself and verifies that we make the appropriate call (there
is (hopefully) sufficient test coverage that the updater DTRT elsewhere).

Ohhhh, quite right.  R=me, then.