[webkit-reviews] review granted: [Bug 73634] [GTK] Add TextureMapper ImageBuffer support as a fallback from the hardware accelerated path : [Attachment 146829] Proposed patch

[bugzilla-daemon at webkit.org]

Martin Robinson <mrobinson at webkit.org> has granted Alejandro G. Castro
<alex at igalia.com>'s request for review:
Bug 73634: [GTK] Add TextureMapper ImageBuffer support as a fallback from the
hardware accelerated path
https://bugs.webkit.org/show_bug.cgi?id=73634

Attachment 146829: Proposed patch
https://bugs.webkit.org/attachment.cgi?id=146829&action=review

------- Additional Comments from Martin Robinson <mrobinson at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=146829&action=review


Okay. This is a good start. Now we just need to unify the GL and ImageBuffer
implementations.

> Source/WebCore/platform/graphics/cairo/GraphicsContext3DPrivate.cpp:99
> +	   // OpenGL keeps the pixels stored bottom up, so we need to flip the
image here.
> +	   context->translate(0, height);
> +	   context->scale(FloatSize(1, -1));

I think you want to translate and scale before applying the compositing matrix,
but I'm not certain.

> Source/WebCore/platform/graphics/cairo/GraphicsContext3DPrivate.h:43
> +    void paintToCanvasRect(const unsigned char* imagePixels, int imageWidth,
int imageHeight, const FloatRect& canvasRect, PlatformContextCairo*);

I guess this was added accidentally? I don't see the implementation anywhere.

> Source/WebKit/gtk/WebCoreSupport/ChromeClientGtk.cpp:544
> +

This newline seems to be added accidentally as well.