[webkit-reviews] review granted: [Bug 88840] GC should be 1.7X faster : [Attachment 147019] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Jun 12 11:39:07 PDT 2012
Oliver Hunt <oliver at apple.com> has granted Geoffrey Garen <ggaren at apple.com>'s
request for review:
Bug 88840: GC should be 1.7X faster
https://bugs.webkit.org/show_bug.cgi?id=88840
Attachment 147019: Patch
https://bugs.webkit.org/attachment.cgi?id=147019&action=review
------- Additional Comments from Oliver Hunt <oliver at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=147019&action=review
Makes me wonder if we should be looking at other Mutex users and seeing if
spinlocks would be more appropriate...
> Source/JavaScriptCore/runtime/Options.cpp:198
> + // We don't scale so well beyond 6.
> + if (cpusToUse > 6)
> + cpusToUse = 6;
Can't we use a constant here rather than a magic number that gets repeated?
More information about the webkit-reviews
mailing list