[webkit-reviews] review granted: [Bug 85439] Add dpi to css3-images image-resolution : [Attachment 147047] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jun 12 10:59:45 PDT 2012


Tony Chang <tony at chromium.org> has granted David Barr
<davidbarr at chromium.org>'s request for review:
Bug 85439: Add dpi to css3-images image-resolution
https://bugs.webkit.org/show_bug.cgi?id=85439

Attachment 147047: Patch
https://bugs.webkit.org/attachment.cgi?id=147047&action=review

------- Additional Comments from Tony Chang <tony at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=147047&action=review


> LayoutTests/fast/css/image-resolution/image-resolution.html:64
> +var resolutions = ['0dppx', '1dppx', '2dppx', '3dppx', '4dppx',
> +		      '0dpi', '96dpi', '192dpi', '288dpi', '384dpi',
> +		      '150dpi', '300dpi', '450dpi', '600dpi', ''];

Should we test some fractional values?	What about negative numbers?


More information about the webkit-reviews mailing list