[webkit-reviews] review requested: [Bug 88569] Chromium Mac:=?UTF-8?Q?=20don=E2=80=99t=20=23include=20things=20in=20subframeworks=20of=20ApplicationServices?=.framework : [Attachment 147097] Don’t use SKIA_ON_MAC_CHROMIUM

[bugzilla-daemon at webkit.org]

Mark Mentovai <mark at chromium.org> has asked  for review:
Bug 88569: Chromium Mac: don’t #include things in subframeworks of
ApplicationServices.framework
https://bugs.webkit.org/show_bug.cgi?id=88569

Attachment 147097: Don’t use SKIA_ON_MAC_CHROMIUM
https://bugs.webkit.org/attachment.cgi?id=147097&action=review

------- Additional Comments from Mark Mentovai <mark at chromium.org>
I don’t think that the divergent paths for #includes are worth worrying about.
<ApplicationServices/ApplicationServices.h> brings in both
<CoreGraphics/CGGeometry.h> and <CoreText/CoreText.h>, and more. I’m not sure
if that change is desirable for the Apple CG port, which appears content (on
the basis of the existing code) to reach into subframeworks in this manner, and
both CoreGraphics and CoreText have been promoted to top-level frameworks in
SDKs newer than what Chrome can build with.

This version of the patch assumes that OS(DARWIN) && PLATFORM(CHROMIUM) is
always Skia, and doesn’t use SKIA_ON_MAC_CHROMIUM at all.