[webkit-reviews] review granted: [Bug 88820] Padding and borders can cause integer overflow in block layouts : [Attachment 146977] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Jeffrey Pfau <jeffrey at endrift.com>'s
request for review:
Bug 88820: Padding and borders can cause integer overflow in block layouts
https://bugs.webkit.org/show_bug.cgi?id=88820

Attachment 146977: Patch
https://bugs.webkit.org/attachment.cgi?id=146977&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=146977&action=review


Looks good. I wish for a slightly clearer idiom for addition with pinning,
maybe a helper function, but this does seem OK as is.

> LayoutTests/fast/block/block-size-integer-overflow.html:14
> +    window.layoutTestController.dumpAsText();

Since this is a dumpAsText test, it would be nice if the test itself explained
that it was testing, how, and why, with a bit of text in the page.